Re: [PATCH v2 0/4] optimize the bfq queue idle judgment

[Paolo Valente]

> Il giorno 6 ago 2021, alle ore 04:08, Yu Kuai <yukuai3@xxxxxxxxxx> ha scritto:
> 
> Chagnes in V2:
> - as suggested by Paolo, add support to track if root_group have any
> pending requests, and use that to handle the situation when only one
> group is activated while root group doesn't have any pending requests.
> - modify commit message in patch 2
> 

Hi,
sorry for my delay.  I've just finished reviewing your new patches.
As I already said, I like the improvement you are making.  Now the way
you make it also seems effective to me.  I still have a design
concern.  You will find it in my detailed comments on your patches.

Thanks
Paolo

> Yu Kuai (4):
>  block, bfq: add support to track if root_group have any pending
>    requests
>  block, bfq: do not idle if only one cgroup is activated
>  block, bfq: add support to record request size information
>  block, bfq: consider request size in bfq_asymmetric_scenario()
> 
> block/bfq-iosched.c | 69 ++++++++++++++++++++++++++++++++++++++-------
> block/bfq-iosched.h | 29 +++++++++++++++++--
> block/bfq-wf2q.c    | 37 +++++++++++++++---------
> 3 files changed, 110 insertions(+), 25 deletions(-)
> 
> -- 
> 2.31.1
>