Re: [Linux-cachefs] [PATCH v2 04/12] fscache: Add a cookie debug ID and use that in traces

[Marc Dionne]

On Fri, Aug 27, 2021 at 9:31 AM David Howells <dhowells@xxxxxxxxxx> wrote:
>
>
> Add a cookie debug ID and use that in traces and in procfiles rather than
> displaying the (hashed) pointer to the cookie.  This is easier to correlate
> and we don't lose anything when interpreting oops output since that shows
> unhashed addresses and registers that aren't comparable to the hashed
> values.
>
> Changes:
>
> ver #2:
>  - Fix the fscache_op tracepoint to handle a NULL cookie pointer.
>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
> cc: linux-cachefs@xxxxxxxxxx
> Link: https://lore.kernel.org/r/158861210988.340223.11688464116498247790.stgit@xxxxxxxxxxxxxxxxxxxxxx/ # rfc
> Link: https://lore.kernel.org/r/159465769844.1376105.14119502774019865432.stgit@xxxxxxxxxxxxxxxxxxxxxx/
> Link: https://lore.kernel.org/r/160588459097.3465195.1273313637721852165.stgit@xxxxxxxxxxxxxxxxxxxxxx/ # rfc
> Link: https://lore.kernel.org/r/162431193544.2908479.17556704572948300790.stgit@xxxxxxxxxxxxxxxxxxxxxx/

Reviewed-by: Marc Dionne <marc.dionne@xxxxxxxxxxxx>

Marc