Re: [PATCH v2 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1

From: Guenter Roeck
Date: Sat Aug 28 2021 - 12:24:00 EST


On Wed, Aug 04, 2021 at 11:57:15PM -0500, Samuel Holland wrote:
> D1 keeps the same register layout and clock sources as the R329, but it
> adds a key field which must be set to update the watchdog's "CFG" and
> "MODE" registers. Therefore it is not backward-compatible.
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> Acked-by: Maxime Ripard <maxime@xxxxxxxxxx>

Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
> Changes v1 to v2:
> - None.
>
> .../devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> index 8fa5b0d32381..6ef5e7caae80 100644
> --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> @@ -29,6 +29,7 @@ properties:
> - items:
> - const: allwinner,suniv-f1c100s-wdt
> - const: allwinner,sun4i-a10-wdt
> + - const: allwinner,sun20i-d1-wdt
>
> reg:
> maxItems: 1
> @@ -61,6 +62,7 @@ if:
> compatible:
> contains:
> enum:
> + - allwinner,sun20i-d1-wdt
> - allwinner,sun50i-r329-wdt
>
> then: