Re: [PATCH v3 2/2] iio: accel: Add driver support for ADXL313

From: Andy Shevchenko
Date: Sun Aug 29 2021 - 10:20:03 EST


On Wed, Aug 18, 2021 at 11:02 PM Lucas Stankus
<lucas.p.stankus@xxxxxxxxx> wrote:
> On Thu, Aug 12, 2021 at 8:06 AM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Thu, Aug 12, 2021 at 12:19 AM Lucas Stankus
> > <lucas.p.stankus@xxxxxxxxx> wrote:

...

> > > + return regmap_update_bits(data->regmap, ADXL313_REG_BW_RATE,
> > > + ADXL313_RATE_MSK,
> >
> > > + FIELD_PREP(ADXL313_RATE_MSK,
> > > + ADXL313_RATE_BASE + i));
> >
> > One line?
> >
>
> Line to long, 87 chars =/

I think it's fine in this case. It will keep the entire FIELD_PREP()
on one line.

--
With Best Regards,
Andy Shevchenko