Re: [PATCH v2] platform/chrome: cros_ec_trace: Fix format warnings

[Gwendal Grignou]

Fixed in V3.
Thanks,
Gwendal.

On Thu, Aug 26, 2021 at 10:21 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
>
> 25.08.2021 21:18, Gwendal Grignou пишет:
> > Fix printf format issues in new tracing events.
> >
> > Fixes: 814318242 ("platform/chrome: cros_ec_trace: Add fields to command traces")
> >
> > Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> > ---
> > Changes since v1:
> > - Use %u instead of %d for ec timestamp, it is presented as a u32.
> >
> >  drivers/platform/chrome/cros_ec_trace.h | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_trace.h b/drivers/platform/chrome/cros_ec_trace.h
> > index f50b9f9b8610..9d0c848af310 100644
> > --- a/drivers/platform/chrome/cros_ec_trace.h
> > +++ b/drivers/platform/chrome/cros_ec_trace.h
> > @@ -92,7 +92,7 @@ TRACE_EVENT(cros_ec_sensorhub_timestamp,
> >               __entry->current_time = current_time;
> >               __entry->delta = current_timestamp - current_time;
> >       ),
> > -     TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> > +     TP_printk("ec_ts: %9d, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
>
> ec_ts unsigned
>
> >                 __entry->ec_sample_timestamp,
> >               __entry->ec_fifo_timestamp,
> >               __entry->fifo_timestamp,
> > @@ -122,7 +122,7 @@ TRACE_EVENT(cros_ec_sensorhub_data,
> >               __entry->current_time = current_time;
> >               __entry->delta = current_timestamp - current_time;
> >       ),
> > -     TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> > +     TP_printk("ec_num: %4d, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
>
> ec_num unsigned
>