Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings

From: Sasha Levin
Date: Mon Aug 30 2021 - 15:22:36 EST

On Mon, Aug 30, 2021 at 09:57:51AM +0200, Michael Riesch wrote:
Hi ChenYu,

On 8/29/21 7:48 PM, Chen-Yu Tsai wrote:

On Mon, Aug 23, 2021 at 10:39 PM Michael Riesch
<michael.riesch@xxxxxxxxxxxxxx> wrote:

This reverts commit 2c896fb02e7f65299646f295a007bda043e0f382
"net: stmmac: dwmac-rk: add pd_gmac support for rk3399" and fixes
unbalanced pm_runtime_enable warnings.

In the commit to be reverted, support for power management was
introduced to the Rockchip glue code. Later, power management support
was introduced to the stmmac core code, resulting in multiple
invocations of pm_runtime_{enable,disable,get_sync,put_sync}.

The multiple invocations happen in rk_gmac_powerup and
stmmac_{dvr_probe, resume} as well as in rk_gmac_powerdown and
stmmac_{dvr_remove, suspend}, respectively, which are always called
in conjunction.

Signed-off-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx>

I just found that Ethernet stopped working on my RK3399 devices,
and I bisected it down to this patch.

Oh dear. First patch in a kernel release for a while and I already break

Cc: Sasha as this patch has just been applied to 5.13-stable.

I'll drop it for now, thanks for letting me know!