Re: [PATCH 7/7] arm64: dts: ls1028a: use phy-mode instead of phy-connection-type

[Michael Walle]

Am 2021-08-31 15:59, schrieb Vladimir Oltean:
> On Tue, Aug 31, 2021 at 03:40:13PM +0200, Michael Walle wrote:
> > In linux both are identical, phy-mode is used more often, though. Also
> > for the ls1028a both phy-connection-type and phy-mode was used, one 
> > for
> > the enetc nodes and the other for the switch nodes. Unify them. But 
> > the
> > main reason for this is that the device tree files can be shared with
> > the u-boot ones; there the enetc driver only supports the "phy-mode"
> > property.
> >
> > Suggested-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> > Signed-off-by: Michael Walle <michael@xxxxxxxx>
> > ---
>
> Actually that is not really a valid reason in itself for this change.
> The enetc U-Boot driver is perhaps a bit silly in that it calls
> ofnode_read_string(dev_ofnode(dev), "phy-mode") manually, especially
> since right below, it uses dm_eth_phy_connect() which searches for 
> both.
>
> So we are artificially restricting what we support. It would be fine to
> do the dm_eth_phy_connect first, then use phy->interface for 
> enetc_start_pcs().

You mean in u-boot. I had a patch for it, but because you suggested
to convert it to the new property name, it isn't really needed anyway.
u-boot is just using the device trees within its source tree, so I
didn't care anymore ;)

> Anyway, I do not mind the patch at all.
>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Thanks!

-michael