Re: [PATCH 4/6] mm/page_alloc.c: use helper function zone_spans_pfn()

[David Hildenbrand]

On 30.08.21 16:10, Miaohe Lin wrote:
> Use helper function zone_spans_pfn() to check whether pfn is within a
> zone to simplify the code slightly.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> ---
>   mm/page_alloc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index b5edcfe112aa..7bb79e959ab4 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1576,7 +1576,7 @@ static void __meminit init_reserved_page(unsigned long pfn)
>   	for (zid = 0; zid < MAX_NR_ZONES; zid++) {
>   		struct zone *zone = &pgdat->node_zones[zid];
>   
> -		if (pfn >= zone->zone_start_pfn && pfn < zone_end_pfn(zone))
> +		if (zone_spans_pfn(zone, pfn))
>   			break;
>   	}
>   	__init_single_page(pfn_to_page(pfn), pfn, zid, nid);

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb