Re: [PATCH V6 4/7] arm64: dts: sc7280: Update QUPv3 UART5 DT node

[rajpat]

On 2021-08-27 02:31, Matthias Kaehlcke wrote:
> On Thu, Aug 26, 2021 at 06:45:28PM +0530, Rajesh Patil wrote:
> > From: Roja Rani Yarubandi <rojay@xxxxxxxxxxxxxx>
> >
> > Update the compatible string as "qcom,geni-uart".
> > Add interconnects and power-domains. Split the pinctrl
> > functions and correct the gpio pins.
>
> You could say that uart5 was formerly treated as special
> (dedicated debug uart) and that the change removes this
> specialness and makes it look like any other UART.

Okay

> > split the pinctrl functions to match with SoC dt
>
> The message should say that this is about the 7280-idp
>
> > Signed-off-by: Roja Rani Yarubandi <rojay@xxxxxxxxxxxxxx>
> > Signed-off-by: Rajesh Patil <rajpat@xxxxxxxxxxxxxx>
>
> The change itself looks good to me, the above are only nits to improve
> the commit message, so:
>
> Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>