Re: [PATCH] net: NET_VENDOR_LITEX should depend on LITEX

[Geert Uytterhoeven]

Hi Joel,

On Tue, Aug 31, 2021 at 3:37 PM Joel Stanley <joel@xxxxxxxxx> wrote:
> On Tue, 31 Aug 2021 at 13:21, Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
> > LiteX Ethernet devices are only present on LiteX SoCs.  Hence add a
> > dependency on LITEX, to prevent asking the user about drivers for these
> > devices when configuring a kernel without LiteX SoC Builder support.
>
> nak.
>
> They can be present on any soc that uses them. We have an example in
> mainline already; microwatt uses liteeth but is not a litex soc.

But liiteeth.c uses <linux/litex.h>?
And https://github.com/enjoy-digital/litex can be used with a microwatt
CPU core?

The idea behind the LITEX config symbol was to gate off any driver
using LiteX interfaces.

> > Fixes: ee7da21ac4c3be1f ("net: Add driver for LiteX's LiteETH network interface")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> > --- a/drivers/net/ethernet/litex/Kconfig
> > +++ b/drivers/net/ethernet/litex/Kconfig
> > @@ -5,6 +5,7 @@
> >  config NET_VENDOR_LITEX
> >         bool "LiteX devices"
> >         default y
> > +       depends on LITEX || COMPILE_TEST
> >         help
> >           If you have a network (Ethernet) card belonging to this class, say Y.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds