Re: [PATCH v4 2/4] dt-bindings: interrupt-controller: msi: Add msi-ranges property

From: Rob Herring
Date: Tue Aug 31 2021 - 17:16:08 EST


On Fri, Aug 27, 2021 at 07:15:27PM +0200, Mark Kettenis wrote:
> From: Mark Kettenis <kettenis@xxxxxxxxxxx>
>
> Update the MSI controller binding to add an msi-ranges property
> that specifies how MSIs map onto regular interrupts on some other
> interrupt controller.
>
> Signed-off-by: Mark Kettenis <kettenis@xxxxxxxxxxx>
> ---
> .../bindings/interrupt-controller/msi-controller.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml b/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml
> index 5ed6cd46e2e0..bf8b8a7dba09 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml
> @@ -31,4 +31,12 @@ properties:
> Identifies the node as an MSI controller.
> $ref: /schemas/types.yaml#/definitions/flag
>
> + msi-ranges:
> + description:
> + A list of pairs <intid span>, where "intid" is the specification

It's not really 'pairs' and 'interrupt specifier' is the terminology the
spec uses. How about:

A list of <phandle intspec span>, where "phandle" is parent interrupt
controller, "intspec" is the starting/base interrupt specifier, and
"span" is the size of that range (typically multiples of 32).

The 'multiples of 32' part is what Marc told me.

> + of the first interrupt (including the phandle for the interrupt
> + controller) that can be used as an MSI, and "span" the size of
> + that range. Multiple ranges can be provided.
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> +
> additionalProperties: true
> --
> 2.32.0
>
>