RE: [PATCH V6 1/1] interconnect: intel: Add Keem Bay noc driver

[N, Pandith]

Hi

> -----Original Message-----
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Sent: Tuesday, August 31, 2021 9:46 PM
> To: N, Pandith <pandith.n@xxxxxxxxx>; georgi.djakov@xxxxxxxxxx; linux-
> pm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: mgross@xxxxxxxxxxxxxxx; Zhou, Furong <furong.zhou@xxxxxxxxx>;
> Sangannavar, Mallikarjunappa <mallikarjunappa.sangannavar@xxxxxxxxx>; Raja
> Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@xxxxxxxxx>
> Subject: Re: [PATCH V6 1/1] interconnect: intel: Add Keem Bay noc driver
> 
> Hi--
> 
> On 8/30/21 11:36 PM, pandith.n@xxxxxxxxx wrote:
> > diff --git a/drivers/interconnect/intel/Kconfig
> > b/drivers/interconnect/intel/Kconfig
> > new file mode 100644
> > index 000000000000..a2f933773380
> > --- /dev/null
> > +++ b/drivers/interconnect/intel/Kconfig
> > @@ -0,0 +1,19 @@
> > +# Copyright (C) 2019 Intel Corporation # SPDX-License-Identifier:
> > +GPL-2.0-only config INTERCONNECT_INTEL
> > +	bool "Intel Network-on-chip interconnect drivers"
> > +	help
> > +	  Support for Intel's Network on chip interconnect hardware.
> > +
> > +config INTERCONNECT_INTEL_KEEMBAY
> > +	tristate "Intel Keem Bay Enable DDR profiling using NOC"
> > +	depends on INTERCONNECT_INTEL || ARCH_KEEMBAY ||
> COMPILE_TEST
> > +	help
> > +	  Enable this option for DDR bandwidth measurements using NOC
> 
> 	                                                          NOC.
> 
will change it to NOC.
> > +
> > +	  Add support for Network-on-chip (NOC) in DDR Subsystem(DSS).
> 
> 	                                               Subsystem (DSS).
> 
> > +	  DSS NOC has capabilities to enable and get statistics profiling.
> > +	  NOC driver enables features to configure and capture NOC probe
> > +          counters, needed for DSS bandwidth measurement.
> 
> Indent above with tab + 2 spaces instead of many spaces.
> 
Accepted, tab +2 space in last line 

> > +	  Say Y if using a processor that includes the Intel VPU such as
> > +	  Keem Bay.  If unsure, say N.
> 
> 
> --
> ~Randy

Regards,
Pandith