Re: [PATCH] media: coda: Make use of the helper function devm_platform_ioremap_resource()

[Philipp Zabel]

On Wed, 2021-09-01 at 13:51 +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
> ---
>  drivers/media/platform/coda/imx-vdoa.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/coda/imx-vdoa.c b/drivers/media/platform/coda/imx-vdoa.c
> index 8bc0d8371819..6996d4571e36 100644
> --- a/drivers/media/platform/coda/imx-vdoa.c
> +++ b/drivers/media/platform/coda/imx-vdoa.c
> @@ -301,8 +301,7 @@ static int vdoa_probe(struct platform_device *pdev)
>  		return PTR_ERR(vdoa->vdoa_clk);
>  	}
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	vdoa->regs = devm_ioremap_resource(vdoa->dev, res);
> +	vdoa->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(vdoa->regs))
>  		return PTR_ERR(vdoa->regs);
>  

Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

regards
Philipp