RE: [PATCH 0/2] arm: aspeed: Add LPC uart routing support

[ChiaWei Wang]

Hi Joel,

> From: Joel Stanley <joel@xxxxxxxxx>
> Sent: Wednesday, September 1, 2021 3:04 PM
> 
> On Wed, 1 Sept 2021 at 06:22, Chia-Wei Wang
> <chiawei_wang@xxxxxxxxxxxxxx> wrote:
> >
> > Add LPC uart routing driver and the device tree nodes.
> 
> Thanks for submitting this driver. There are many parties who are interested in
> this, so hopefully they can step forward and review.
> 
> Is this LPC UART routing, or UART routing in general? I know the register to
> control the routing is hidden in the LPC space, but I thought it was just general
> routing. I would drop the LPC part of the name.
> 
> You also need to update the bindings document with the new compatible string.
> Send a patch for Documentation/devicetree/bindings/mfd/aspeed-lpc.txt.

Thanks for the feedback.

The UART routing is general.
I will send a v2 patch which drops the LPC part of name.
And the compatible string will also be updated to the dt-bindings.

Chiawei