Re: [PATCH] media: rcar_fdp1: Make use of the helper function devm_platform_ioremap_resource()

[Kieran Bingham]

On 01/09/2021 06:55, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>

> Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
> ---
>  drivers/media/platform/rcar_fdp1.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c
> index 89aac60066d9..19de3c19bcca 100644
> --- a/drivers/media/platform/rcar_fdp1.c
> +++ b/drivers/media/platform/rcar_fdp1.c
> @@ -2256,7 +2256,6 @@ static int fdp1_probe(struct platform_device *pdev)
>  	struct fdp1_dev *fdp1;
>  	struct video_device *vfd;
>  	struct device_node *fcp_node;
> -	struct resource *res;
>  	struct clk *clk;
>  	unsigned int i;
>  
> @@ -2283,8 +2282,7 @@ static int fdp1_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, fdp1);
>  
>  	/* Memory-mapped registers */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	fdp1->regs = devm_ioremap_resource(&pdev->dev, res);
> +	fdp1->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(fdp1->regs))
>  		return PTR_ERR(fdp1->regs);
>  
>