Re: [PATCH v2] x86/setup: Explicitly include acpi.h

[Linus Torvalds]

On Wed, Sep 1, 2021 at 9:09 AM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>
> After commit 342f43af70db ("iscsi_ibft: fix crash due to KASLR physical
> memory remapping") x86_64_defconfig shows the following errors:

Strange. I wonder why I didn't see that - not even in my smaller config builds.

> acpi.h was being implicitly included from iscsi_ibft.h in this
> configuration so the removal of that header means these functions have
> no definition or declaration. Add acpi.h explicitly so there is no more
> error.

The patch is clearly ok, I wonder what way _my_ config included acpi.h
ended up coming in..

[ Goes off and looks. Oh, because I got it from <linux/tboot.h> and
had CONFIG_INTEL_TXT enabled. ]

> Linus, would you mind taking this directly?

Will do.

           Linus