Re: [PATCH v2 05/14] [net-next] cs89x0: rework driver configuration

[Guenter Roeck]

On Tue, Aug 03, 2021 at 01:40:42PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> There are two drivers in the cs89x0 file, with the CONFIG_CS89x0_PLATFORM
> symbol deciding which one is getting built. This is somewhat confusing
> and makes it more likely ton configure a driver that works nowhere.
> 
> Split up the Kconfig option into separate ISA and PLATFORM drivers,
> with the ISA symbol explicitly connecting to the static probing in
> drivers/net/Space.c
> 
> The two drivers are still mutually incompatible at compile time,
> which could be lifted by splitting them into multiple files,
> but in practice this will make no difference.
> 
> The platform driver can now be enabled for compile-testing on
> non-ARM machines.
> 

powerpc:allmodconfig in mainline (I tested v5.14-3756-gd8b4266666c4 and
v5.14-4526-gebf435d3b51b):

drivers/net/ethernet/cirrus/cs89x0.c: In function 'net_open':
drivers/net/ethernet/cirrus/cs89x0.c:897:41: error: implicit declaration of function 'isa_virt_to_bus'

Guenter