Re: [PATCH] Fix formatting for file "hsdma-mt7621.c" by fixing formatting of lines ending with "("

[Greg KH]

On Wed, Sep 01, 2021 at 10:58:55PM +0200, Krish Jain wrote:
> From: Krish Jain <krishjain02939@xxxxxxxxx>
> 
> This patch fixes the format of the code. It properly formats lines
> that should not end with a '(' as suggested by checkpath.pl.
> 
> Signed-off-by: Krish Jain <krishjain02939@xxxxxxxxx>
> 
> ---
>  drivers/staging/mt7621-dma/hsdma-mt7621.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c
> b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> index b0ed935de7ac..89b72a802800 100644
> --- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
> +++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> @@ -162,8 +162,7 @@ struct mtk_hsdam_engine {
>   struct mtk_hsdma_chan chan[1];
>  };
> 
> -static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(
> - struct mtk_hsdma_chan *chan)
> +static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(struct
> mtk_hsdma_chan *chan)
>  {
>   return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine,
>   ddev);
> @@ -174,8 +173,7 @@ static inline struct mtk_hsdma_chan
> *to_mtk_hsdma_chan(struct dma_chan *c)
>   return container_of(c, struct mtk_hsdma_chan, vchan.chan);
>  }
> 
> -static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(
> - struct virt_dma_desc *vdesc)
> +static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(struct
> virt_dma_desc *vdesc)
>  {
>   return container_of(vdesc, struct mtk_hsdma_desc, vdesc);
>  }
> @@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
>   spin_unlock_bh(&chan->vchan.lock);
>  }
> 
> -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> - struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> - size_t len, unsigned long flags)
> +static struct dma_async_tx_descriptor
> *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest,
> dma_addr_t src, size_t len, unsigned long flags)
>  {
>   struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
>   struct mtk_hsdma_desc *desc;
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot