Re: [PATCH v1 04/20] x86/resctrl: Add domain offline callback for resctrl work

[Reinette Chatre]

Hi James,

On 7/29/2021 3:35 PM, James Morse wrote:
> Because domains are exposed to user-space via resctrl, the filesystem
> must update its state when cpu hotplug callbacks are triggered.

cpu -> CPU please.

> Some of this work is common to any architecture that would support
> resctrl, but the work is tied up with the architecture code to
> free the memory.
>
> Move the monitor subdir removal and the cancelling of the mbm/limbo
> works into a new resctrl_offline_domain() call.

Same as previous patch, could you please elaborate how the code change 
you describe fixes the problem you state earlier.

...

> +void resctrl_offline_domain(struct rdt_resource *r, struct rdt_domain *d)
> +{
> +	lockdep_assert_held(&rdtgroup_mutex); // the arch code took this for us
> +

No trailing comments please.

Reinette