Re: [PATCH v10 0/6] Re-introduce TX FIFO resize for larger EP bursting

From: Jack Pham
Date: Wed Sep 01 2021 - 20:28:23 EST


Hi Thinh,

On Sat, Aug 21, 2021 at 02:57:07AM +0000, Thinh Nguyen wrote:
> I took a look at 24f779dac8f3 ("usb: gadget: f_uac2/u_audio: add
> feedback endpoint support") that Ferry reported the issue from
> bisection. I see at least a couple problems in the new UAC2 changes.
>
> 1) usb_ep_dequeue() is asynchronous. Don't free requests before the
> controller driver give them back.
>
> 2) Did you test with SuperSpeed? I don't see companion descriptor.

We caught this too when testing f_uac2 in SuperSpeed mode. I can
prepare a patch.

Thanks,
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project