Re: [PATCH 00/24] x86/entry/64: Convert a bunch of ASM entry code into C code
From: Peter Zijlstra
Date: Thu Sep 02 2021 - 03:45:37 EST
On Thu, Sep 02, 2021 at 02:28:43PM +0800, Lai Jiangshan wrote:
>
>
> On 2021/9/1 04:44, Peter Zijlstra wrote:
> > On Wed, Sep 01, 2021 at 01:50:01AM +0800, Lai Jiangshan wrote:
> > > From: Lai Jiangshan <laijs@xxxxxxxxxxxxxxxxx>
> > >
> > > Many ASM code in entry_64.S can be rewritten in C if they can be written
> > > to be non-instrumentable and are called in the right order regarding to
> > > whether CR3/gsbase is changed to kernel CR3/gsbase.
> > >
> > > The patchset covert some of them to C code.
> >
> > Overall, very nice! There's a lot of details to verify, but I really
> > like where this ends up.
> >
> > I'm not sure about moving traps.c, but whatever, that's simple stuff.
> > I'll try and put some more eyeballs on this later.
> >
>
> Hello, Peter
>
> How is it going?
Too much patches in the inbox, sorry :/
> Do I need to send a new version?
Not at this time.
> How can I cooperate or participate in the details?
What I meant was that review of these patches will have to check all the
details which will take some time.
> Do you plan to move the other path of ASM code into C code?
I do have some plans, but currently a total lack of time. Your patches
are a nice contribution.