Re: [PATCH] media: rcar_jpu: Make use of the helper function devm_platform_ioremap_resource()

[Kieran Bingham]

+Cc linux-renesas-soc

On 01/09/2021 06:55, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>


> ---
>  drivers/media/platform/rcar_jpu.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/rcar_jpu.c b/drivers/media/platform/rcar_jpu.c
> index f57158bf2b11..56bb464629ed 100644
> --- a/drivers/media/platform/rcar_jpu.c
> +++ b/drivers/media/platform/rcar_jpu.c
> @@ -1590,7 +1590,6 @@ MODULE_DEVICE_TABLE(of, jpu_dt_ids);
>  static int jpu_probe(struct platform_device *pdev)
>  {
>  	struct jpu *jpu;
> -	struct resource *res;
>  	int ret;
>  	unsigned int i;
>  
> @@ -1603,8 +1602,7 @@ static int jpu_probe(struct platform_device *pdev)
>  	jpu->dev = &pdev->dev;
>  
>  	/* memory-mapped registers */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	jpu->regs = devm_ioremap_resource(&pdev->dev, res);
> +	jpu->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(jpu->regs))
>  		return PTR_ERR(jpu->regs);
>  
>