Re: [PATCH v7] Bluetooth: btusb: Add support using different nvm for variant WCN6855 controller

[kernel test robot]

Hi Zijun,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on linus/master v5.14 next-20210902]
[cannot apply to linux/master bluetooth/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zijun-Hu/Bluetooth-btusb-Add-support-using-different-nvm-for-variant-WCN6855-controller/20210902-165857
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: i386-randconfig-s002-20210831 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-348-gf0e6938b-dirty
        # https://github.com/0day-ci/linux/commit/971383be35e3681a6e8b1e85ad3c01f21f4e0076
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zijun-Hu/Bluetooth-btusb-Add-support-using-different-nvm-for-variant-WCN6855-controller/20210902-165857
        git checkout 971383be35e3681a6e8b1e85ad3c01f21f4e0076
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/bluetooth/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)
   drivers/bluetooth/btusb.c:1871:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1875:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1879:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1883:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1887:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1893:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:3330:28: sparse: sparse: cast to restricted __le32
   drivers/bluetooth/btusb.c:3362:18: sparse: sparse: restricted __le16 degrades to integer
>> drivers/bluetooth/btusb.c:3386:20: sparse: sparse: restricted __le32 degrades to integer
>> drivers/bluetooth/btusb.c:3386:20: sparse: sparse: restricted __le32 degrades to integer

vim +3386 drivers/bluetooth/btusb.c

  3377	
  3378	static int btusb_setup_qca_load_nvm(struct hci_dev *hdev,
  3379					    struct qca_version *ver,
  3380					    const struct qca_device_info *info)
  3381	{
  3382		const struct firmware *fw;
  3383		char fwname[64];
  3384		int err;
  3385	
> 3386		switch (ver->ram_version) {
  3387		case WCN6855_2_0_RAM_VERSION_GF:
  3388		case WCN6855_2_1_RAM_VERSION_GF:
  3389				btusb_generate_qca_nvm_name(fwname, sizeof(fwname), ver, "gf");
  3390			break;
  3391		default:
  3392				btusb_generate_qca_nvm_name(fwname, sizeof(fwname), ver, "");
  3393			break;
  3394		}
  3395	
  3396		err = request_firmware(&fw, fwname, &hdev->dev);
  3397		if (err) {
  3398			bt_dev_err(hdev, "failed to request NVM file: %s (%d)",
  3399				   fwname, err);
  3400			return err;
  3401		}
  3402	
  3403		bt_dev_info(hdev, "using NVM file: %s", fwname);
  3404	
  3405		err = btusb_setup_qca_download_fw(hdev, fw, info->nvm_hdr);
  3406	
  3407		release_firmware(fw);
  3408	
  3409		return err;
  3410	}
  3411	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip