Re: [PATCH 02/24] x86/traps: Move arch/x86/kernel/traps.c to arch/x86/entry/
From: Miguel Ojeda
Date: Thu Sep 02 2021 - 13:19:21 EST
On Thu, Sep 2, 2021 at 7:05 PM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote:
>
> The above 2 hunks should go in include/linux/compiler_attributes.h,
> but yes. I'd been meaning to send such a patch; it's nice to have
Note that `compiler_attributes.h` does not keep attributes that depend
on config options.
On one hand, I feel we should put them there. On the other hand, I
want to avoid making a mess again since the purpose of the file is to
keep things clean for the majority of attributes.
Perhaps we should do a middle-ground, and only allow those that depend
on a single config option, i.e. no nesting `#if`s or complex
conditions.
Cheers,
Miguel