Re: [PATCH v3 2/2] spi: cadence: add support for Cadence XSPI controller

From: Mark Brown
Date: Fri Sep 03 2021 - 06:19:14 EST


On Fri, Sep 03, 2021 at 08:10:38AM +0000, Parshuram Raju Thombare wrote:

> >> + master->mode_bits = SPI_3WIRE | SPI_TX_DUAL | SPI_TX_QUAD |
> >> + SPI_RX_DUAL | SPI_RX_QUAD | SPI_TX_OCTAL | SPI_RX_OCTAL
> >|
> >> + SPI_MODE_0 | SPI_MODE_3;

> >I don't see any handling of these in the code?

> This is just to declare controller's capability, so that spi_setup() can modify
> spi->mode according to the capability of attached device.

In order for this to work I would expect there to be code in the driver
which configures the controller into the specified mode.

Attachment: signature.asc
Description: PGP signature