Re: [PATCH] regulator: core: resolve supply voltage deferral silently
From: Brian Norris
Date: Fri Sep 03 2021 - 13:09:32 EST
On Fri, Sep 3, 2021 at 4:11 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
> In terms of not understanding the issue here is that the patch didn't
> pass the smell test, it was your explanation that helped here not the
> pointing at a driver change that lacks obvious relevance. I really
> don't know what the reader is supposed to infer about the change from
> the commit,
OK, I might see where you're coming from. Personally, I'd still like
to reference the commit in some way, because I've never used bypass
mode that I'm aware of, but the mentioned commit added a new case that
I do care about. I like documenting motivation, where reasonable --
but apparently I need to do a better job of that part.
> I don't think anyone came up with anything more tasteful to do with that
> hardware, like I say the hardware is itself very hacky.
OK. I guess I was specifically asking about this patch (and the new
usage of ->supply in commit 21e39809fd7c, to some extent). If the
usage of ->supply is the best we can/should do, then we can leave
21e39809fd7c alone. If you don't care to "fix" this log message, then
I can forget about $subject patch too.
Or, do you only want me to improve the commit message (drop the Fixes,
mention bypass mode, etc.) and resubmit?
Brian