Re: [PATCH] drm/msm: remove unneeded variable

[Dmitry Baryshkov]

On 02/09/2021 21:40, Lyude Paul wrote:
> Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>
>
> Do you need me to push this?

We'd pick this up through the msm tree.

> On Tue, 2021-08-31 at 04:51 -0700, cgel.zte@xxxxxxxxx wrote:
> > From: Chi Minghao <chi.minghao@xxxxxxxxxx>
> >
> > Fix the following coccicheck REVIEW:
> > ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable
> >
> > Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> > Signed-off-by: Chi Minghao <chi.minghao@xxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/msm/edp/edp_ctrl.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c
> > b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> > index 4fb397ee7c84..3610e26e62fa 100644
> > --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
> > +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> > @@ -1242,8 +1242,6 @@ bool msm_edp_ctrl_panel_connected(struct edp_ctrl
> > *ctrl)
> >   int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
> >                  struct drm_connector *connector, struct edid **edid)
> >   {
> > -       int ret = 0;
> > -
> >          mutex_lock(&ctrl->dev_mutex);
> >   
> >          if (ctrl->edid) {
> > @@ -1278,7 +1276,7 @@ int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
> >          }
> >   unlock_ret:
> >          mutex_unlock(&ctrl->dev_mutex);
> > -       return ret;
> > +       return 0;
> >   }
> >   
> >   int msm_edp_ctrl_timing_cfg(struct edp_ctrl *ctrl,


--
With best wishes
Dmitry