Re: [PATCH] docs: pdfdocs: Fix typo in CJK-language specific font settings
From: Akira Yokosawa
Date: Sat Sep 04 2021 - 01:20:28 EST
Hi Jon, [most CCs dropped]
Just a reminder in case you have missed this fix.
On Sun, 29 Aug 2021 11:06:16 +0900, Akira Yokosawa wrote:
> There were typos in the fallback definitions of dummy LaTeX macros
> for systems without CJK fonts.
> They cause build errors in "make pdfdocs" on such systems.
> Fix them.
>
> Fixes: e291ff6f5a03 ("docs: pdfdocs: Add CJK-language-specific font settings")
> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>
> ---
> Hi Jon,
>
> I thought I had tested the v4 patch on a container image
> without any CJK fonts, but apparently I had not.
>
> These typos affect "make pdfdocs" of all the English documents
> as well.
> So, if this doesn't make the initial pull request for v5.15,
> please consider sending it as an urgent pull request during
> -rc stages of v5.15.
I think this regression fix should go to v5.15.
What do you think?
Thanks, Akira
>
> Apologies for the lack of test on my side.
>
> Thanks, Akira
> --
> Documentation/conf.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/conf.py b/Documentation/conf.py
> index 75650f6443af..948a97d6387d 100644
> --- a/Documentation/conf.py
> +++ b/Documentation/conf.py
> @@ -463,8 +463,8 @@ latex_elements['preamble'] += '''
> \\newcommand{\\kerneldocEndTC}{}
> \\newcommand{\\kerneldocBeginKR}{}
> \\newcommand{\\kerneldocEndKR}{}
> - \\newcommand{\\kerneldocBeginSC}{}
> - \\newcommand{\\kerneldocEndKR}{}
> + \\newcommand{\\kerneldocBeginJP}{}
> + \\newcommand{\\kerneldocEndJP}{}
> }
> '''
>
>