Re: [PATCH] input/serio:unneeded variable:delay

[Dmitry Torokhov]

On Tue, Mar 23, 2021 at 03:02:50PM +0800, mateng wrote:
> From: mateng <mateng@xxxxxxxxxx>
> 
> delete unneeded variable 'delay'

Sorry, but this is bogus.

> 
> Signed-off-by: mateng <mateng@xxxxxxxxxx>
> ---
>  drivers/input/serio/i8042.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
> index abae23a..145bda1 100644
> --- a/drivers/input/serio/i8042.c
> +++ b/drivers/input/serio/i8042.c
> @@ -1126,7 +1126,6 @@ static void i8042_controller_reset(bool s2r_wants_reset)
>  
>  static long i8042_panic_blink(int state)
>  {
> -	long delay = 0;
>  	char led;
>  
>  	led = (state) ? 0x01 | 0x04 : 0;
> @@ -1142,7 +1141,7 @@ static long i8042_panic_blink(int state)
>  	dbg("%02x -> i8042 (panic blink)\n", led);
>  	i8042_write_data(led);
>  	DELAY;
> -	return delay;
> +	return 0;
>  }
>  
>  #undef DELAY
> -- 
> 1.9.1
> 

-- 
Dmitry