Re: [linux-rt-devel:linux-5.14.y-rt-rebase 242/262] kernel/locking/spinlock_rt.c:249:13: warning: no previous prototype for 'rt_rwlock_is_contended'
From: Sebastian Andrzej Siewior
Date: Mon Sep 06 2021 - 03:54:05 EST
On 2021-09-05 03:00:56 [+0800], kernel test robot wrote:
> >> kernel/locking/spinlock_rt.c:249:13: warning: no previous prototype for 'rt_rwlock_is_contended' [-Wmissing-prototypes]
> 249 | int __sched rt_rwlock_is_contended(rwlock_t *rwlock)
> | ^~~~~~~~~~~~~~~~~~~~~~
>
>
> vim +/rt_rwlock_is_contended +249 kernel/locking/spinlock_rt.c
>
> ca72c3eba593af Thomas Gleixner 2021-08-15 248
> ca72c3eba593af Thomas Gleixner 2021-08-15 @249 int __sched rt_rwlock_is_contended(rwlock_t *rwlock)
> ca72c3eba593af Thomas Gleixner 2021-08-15 250 {
> ca72c3eba593af Thomas Gleixner 2021-08-15 251 return rw_base_is_contended(&rwlock->rwbase);
> ca72c3eba593af Thomas Gleixner 2021-08-15 252 }
> ca72c3eba593af Thomas Gleixner 2021-08-15 253 EXPORT_SYMBOL(rt_rwlock_is_contended);
> ca72c3eba593af Thomas Gleixner 2021-08-15 254
| $ git grep rwlock_is_contended include/linux/rwlock_rt.h
| include/linux/rwlock_rt.h:#define rwlock_is_contended(lock) (((void)(lock), 0))
shouldn't we wire it up?
Sebastian