Re: [PATCH v2] coresight: syscfg: fix compiler warnings

From: Mathieu Poirier
Date: Mon Sep 06 2021 - 11:06:35 EST


On Mon, Aug 30, 2021 at 10:28:19AM -0700, Jian Cai wrote:
> This fixes warnings with -Wimplicit-function-declaration, e.g.
>
> drivers/hwtracing/coresight/coresight-syscfg.c:455:15: error:
> implicit declaration of function 'kzalloc' [-Werror,
> -Wimplicit-function-declaration]
> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev),
> GFP_KERNEL);
>
> Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Jian Cai <jiancai@xxxxxxxxxx>
> ---
>
> Changes v1 -> v2:
> Format the commit message and add Fixes and Reviewed-by tag.
>
> drivers/hwtracing/coresight/coresight-syscfg.c | 1 +
> 1 file changed, 1 insertion(+)
>

I have applied this patch to my local tree. I will push it to the coresight-next
branch when 5.15-rc1 is published next week.

Thanks,
Mathieu

> diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c
> index fc0760f55c53..43054568430f 100644
> --- a/drivers/hwtracing/coresight/coresight-syscfg.c
> +++ b/drivers/hwtracing/coresight/coresight-syscfg.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/platform_device.h>
> +#include <linux/slab.h>
>
> #include "coresight-config.h"
> #include "coresight-etm-perf.h"
> --
> 2.33.0.259.gc128427fd7-goog
>