Re: [PATCH v3 4/4] arm64: dts: meson-axg: add support for JetHub D1

[Vyacheslav]

06.09.2021 15:26, Neil Armstrong пишет:
> On 04/09/2021 16:27, Vyacheslav Bocharov wrote:
> > JetHome Jethub D1 (http://jethome.ru/jethub-d1) is a home automation
> > controller with the following features:
> >
> > +
> > +&spicc1 {
> > +	status = "okay";
> > +};
> Why enabling it without pinctrl properties ?

spiccwas planned for use during the development of the device, but in 
fact it is not currently used. Pins exist on expand pad.

Its better to add pinctrl as below or leave spicc1 disabled?

diff --git 
a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts 
b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
index bc10f3357c09..ecffc90d9884 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts
@@ -313,6 +313,8 @@ &usb {

 &spicc1 {
        status = "okay";
+       pinctrl-0 = <&spi1_x_pins>, <&spi1_ss0_x_pins>;
+       pinctrl-names = "default";
 };

 &gpio {


--

Vyacheslav