Re: [memcg] 45208c9105: aim7.jobs-per-min -14.0% regression

[Feng Tang]

Hi Shakeel, 

On Sun, Sep 05, 2021 at 03:15:46PM -0700, Shakeel Butt wrote:
> On Sun, Sep 5, 2021 at 5:27 AM kernel test robot <oliver.sang@xxxxxxxxx> wrote:
[...]
> > =========================================================================================
> > compiler/cpufreq_governor/disk/fs/kconfig/load/rootfs/tbox_group/test/testcase/ucode:
> >   gcc-9/performance/1BRD_48G/xfs/x86_64-rhel-8.3/3000/debian-10.4-x86_64-20200603.cgz/lkp-icl-2sp2/disk_rr/aim7/0xd000280
> >
> > commit:
> >   3c28c7680e ("memcg: switch lruvec stats to rstat")
> >   45208c9105 ("memcg: infrastructure to flush memcg stats")
> 
> I am looking into this. I was hoping we have resolution for [1] as
> these patches touch similar data structures.
> 
> [1] https://lore.kernel.org/all/20210811031734.GA5193@xsang-OptiPlex-9020/T/#u

I tried 2 debug methods for that 36.4% vm-scalability regression:

1. Disable the HW cache prefetcher, no effect on this case 
2. relayout and add padding to 'struct cgroup_subsys_state', reduce
   the regression to 3.1%

Thanks,
Feng