Re: [PATCH v2 5/5] ARM: multi_v7_defconfig: Add support for Airoha EN7523 SoC

[Dmitry Osipenko]

07.09.2021 13:41, Bert Vermeulen пишет:
> On 9/7/21 12:39 PM, Dmitry Osipenko wrote:
>> 07.09.2021 13:27, Bert Vermeulen пишет:
>>> From: John Crispin <john@xxxxxxxxxxx>
>>>
>>> This enables basic bootup support for the Airoha EN7523 SoC.
>>>
>>> Signed-off-by: John Crispin <john@xxxxxxxxxxx>
>>> Signed-off-by: Bert Vermeulen <bert@xxxxxxxx>
>>> ---
>>>  arch/arm/configs/multi_v7_defconfig | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/configs/multi_v7_defconfig
>>> b/arch/arm/configs/multi_v7_defconfig
>>> index d9abaae118dd..a9370a95dc38 100644
>>> --- a/arch/arm/configs/multi_v7_defconfig
>>> +++ b/arch/arm/configs/multi_v7_defconfig
>>> @@ -31,6 +31,7 @@ CONFIG_MACH_BERLIN_BG2=y
>>>  CONFIG_MACH_BERLIN_BG2CD=y
>>>  CONFIG_MACH_BERLIN_BG2Q=y
>>>  CONFIG_ARCH_DIGICOLOR=y
>>> +CONFIG_ARCH_AIROHA=y
>>>  CONFIG_ARCH_EXYNOS=y
>>>  CONFIG_ARCH_HIGHBANK=y
>>>  CONFIG_ARCH_HISI=y
>>> @@ -983,6 +984,7 @@ CONFIG_STAGING_BOARD=y
>>>  CONFIG_MFD_CROS_EC_DEV=m
>>>  CONFIG_CROS_EC_I2C=m
>>>  CONFIG_CROS_EC_SPI=m
>>> +CONFIG_COMMON_CLK_EN7523=y
>>
>> If SoC doesn't work without clk support, then this option should be
>> auto-selected by the arch option.
>>
>> It also doesn't look like upstream kernel has COMMON_CLK_EN7523 at all.
> 
> Oops, you're right -- the clock driver is coming as soon as the base
> system is in. I guess this option (under ARCH_AIROHA) should come in at
> that time as well? I'll respin after some more comments.

Probably. You may also make clk driver to use ARCH_AIROHA option
directly if driver is supposed to be used only by that single arch, like
some other platform do that.