Re: [PATCH v3 3/4] dt-bindings: remoteproc: Add fsl,imx-dsp-rproc binding document

From: Rob Herring
Date: Tue Sep 07 2021 - 08:50:29 EST


On Fri, Sep 3, 2021 at 9:58 PM Shengjiu Wang <shengjiu.wang@xxxxxxxxx> wrote:
>
> Hi Rob
>
> On Sat, Sep 4, 2021 at 12:50 AM Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> >
> > On Fri, Sep 3, 2021 at 11:42 AM Rob Herring <robh@xxxxxxxxxx> wrote:
> > >
> > > On Fri, 03 Sep 2021 17:29:36 +0800, Shengjiu Wang wrote:
> > > > Define the compatible string and properties needed by imx_dsp_rproc
> > > > driver.
> > > >
> > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx>
> > > > ---
> > > > .../remoteproc/fsl,imx-dsp-rproc.yaml | 131 ++++++++++++++++++
> > > > 1 file changed, 131 insertions(+)
> > > > create mode 100644 Documentation/devicetree/bindings/remoteproc/fsl,imx-dsp-rproc.yaml
> > > >
> > >
> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> >
> > I take that back. What's the difference with this binding and
> > Documentation/devicetree/bindings/dsp/fsl,dsp.yaml?
>
> Some devices, but two kinds of driver. one for remoteproc
> framework, another one is for ALSA.
> So should I merge fsl,imx-dsp-rproc.yaml to fsl,dsp.yaml?

You can have 100 drivers for all I care, but it's 1 DT binding for 1
piece of h/w.

Rob