Re: [PATCH] Makefile: use -Wno-main in the full kernel tree

[Randy Dunlap]

On 8/16/21 5:33 PM, Linus Torvalds wrote:
> On Fri, Aug 13, 2021 at 2:01 PM Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >  From a quick google, it seems like '-Wmain' means something else for
> > clang. But it is probably ok.
>
> So the warnings that clang gives with -Wmain seem to be much more reasonable.
>
> Which makes me think that the '-Wno-main' thing would likely be better
> as a gcc-only thing.
>
> Maybe something like this instead?
>
>                Linus

Linus,

Can we get your version of this patch merged?


Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Should I resend the full patch?

---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Makefile b/Makefile
index c19d1638da25..a33fba083df7 100644
--- a/Makefile
+++ b/Makefile
@@ -803,6 +803,8 @@ else
 # Disabled for clang while comment to attribute conversion happens and
 # https://github.com/ClangBuiltLinux/linux/issues/636 is discussed.
 KBUILD_CFLAGS += $(call cc-option,-Wimplicit-fallthrough=5,)
+# gcc inanely warns about local variables called 'main'
+KBUILD_CFLAGS += -Wno-main
 endif
 
 # These warnings generated too much noise in a regular build.