Re: [PATCH] Input: ad7879 - Make use of the helper function dev_err_probe()

From: Krzysztof Kozlowski
Date: Thu Sep 16 2021 - 15:30:30 EST


On Thu, 16 Sept 2021 at 17:47, Cai Huoqing <caihuoqing@xxxxxxxxx> wrote:
>
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
> ---
> drivers/input/touchscreen/ad7879.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)


Please do not send patches one by one but group them in a series.

The patches you sent were already sent before:
https://lore.kernel.org/lkml/20200827185829.30096-1-krzk@xxxxxxxxxx/

If such conversion is still applicable (although I have doubts -
preferred is to remove dev_err entirely), then I can rebase my older
series.

Best regards,
Krzysztof