Re: [PATCH 5.13 345/380] KVM: arm64: vgic: move irq->get_input_level into an ops structure

[Sasha Levin]

On Thu, Sep 16, 2021 at 07:25:27PM +0100, Marc Zyngier wrote:
> On Thu, 16 Sep 2021 17:01:42 +0100,
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > From: Marc Zyngier <maz@xxxxxxxxxx>
> >
> > [ Upstream commit db75f1a33f82ad332b6e139c5960e01999969d2c ]
> >
> > We already have the option to attach a callback to an interrupt
> > to retrieve its pending state. As we are planning to expand this
> > facility, move this callback into its own data structure.
> >
> > This will limit the size of individual interrupts as the ops
> > structures can be shared across multiple interrupts.
> >
> > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  arch/arm64/kvm/arch_timer.c |  8 ++++++--
> >  arch/arm64/kvm/vgic/vgic.c  | 14 +++++++-------
> >  include/kvm/arm_vgic.h      | 28 +++++++++++++++++-----------
> >  3 files changed, 30 insertions(+), 20 deletions(-)
>
> As I replied to Sasha earlier, I don't see a good reason to backport
> this, as it doesn't improve anything on its own. Unless there is a
> compelling reason to get this backported, I'd rather see it dropped.

Yes, I'll drop it. I originally brought it as a dependency for a patch
that ended up being dropped. Thanks for pointing it out!

--
Thanks,
Sasha