Re: [PATCH v2] PCI: endpoint: Use sysfs_emit() in "show" functions

From: Krzysztof Wilczyński
Date: Thu Sep 16 2021 - 18:43:54 EST


Hayashi-san,

Thank you for sending this as separate patch.

> Gentle ping, are there any comments?

I am sure Bjorn or Lorenzo will get to this patch soon, it's still marked
as "New" in patchwork, as per:
https://patchwork.kernel.org/project/linux-pci/patch/1630472957-26857-1-git-send-email-hayashi.kunihiko@xxxxxxxxxxxxx/

My "Reviewed-by" still applies, of course.

[...]
> > Convert sprintf() in sysfs "show" functions to sysfs_emit() in order to
> > check for buffer overruns in sysfs outputs.

As Bjorn, or someone else might ask, you could add a short note about this
being configfs, rather than sysfs, and that sysfs_emit() will still work.

Something as per what I said while commenting on the previous patch:
https://lore.kernel.org/all/20210719034313.GA274232@rocinante/

Krzysztof