Re: [PATCH] ARM: select HAVE_FUTEX_CMPXCHG

From: Nick Desaulniers
Date: Thu Sep 16 2021 - 19:31:12 EST


On Thu, Sep 16, 2021 at 3:40 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Mon, Aug 30, 2021 at 11:38 PM Nick Desaulniers
> <ndesaulniers@xxxxxxxxxx> wrote:
>
> > tglx notes:
> > This function [futex_detect_cmpxchg] is only needed when an
> > architecture has to runtime discover whether the CPU supports it or
> > not. ARM has unconditional support for this, so the obvious thing to
> > do is the below.
> >
> > Fixes linkage failure from Clang randconfigs:
> > kernel/futex.o:(.text.fixup+0x5c): relocation truncated to fit: R_ARM_JUMP24 against `.init.text'
> > and boot failures for CONFIG_THUMB2_KERNEL.
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/325
> > Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Reported-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> > Suggested-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
>
> LGTM
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Please put this into Russell's patch tracker!

Done!
https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9122/1
Thanks for the review!

--
Thanks,
~Nick Desaulniers