Re: [PATCH] mm/smaps: Use vma->vm_pgoff directly when counting partial swap

[Peter Xu]

On Fri, Sep 17, 2021 at 12:17:32AM +0200, Vlastimil Babka wrote:
> On 9/16/21 11:58 PM, Peter Xu wrote:
> > linear_page_index(vma, vma->vm_start) of a shmem vma is exactly vm_pgoff.
> 
> Could you use "vma->vm_pgoff + vma_pages(vma)" instead of the other
> linear_page_index() then?

Sure.

> 
> But now I wonder, is smaps_pte_hole() broken? it calls
> shmem_partial_swap_usage with addresses, not pgoffs?

Hmm, that seems true..  I guess it still gets the right number when start==0
and when the vma covers the whole file (which could be the simplest scenario),
but not otherwise.

I'll add a new patch.

Thanks,

-- 
Peter Xu