Re: [PATCH 2/2] drm/qxl: Add qxl dma fence release function

[maobibo]

On 09/15/2021 02:38 PM, Gerd Hoffmann wrote:
> On Tue, Sep 14, 2021 at 02:23:52AM -0400, bibo mao wrote:
>> Add qxl dma fence release function, previously default dma fence
>> release function is used, and fence pointer is used to free 
>> the memory. With this patch, actual qxl release pointer is used
>> to free memory, so that dma fence can put at any place of 
>> struct qxl_release.
> 
> Why?  Is there a problem with struct dma_fence being the first
> element of struct qxl_release?
Yes, there is no problem put it in the first element of struct qxl_release. This patch has no actual use,it is only more flexible. And you can discard this patch if other graphics drivers do the same thing like this.

regards
bibo,mao
> 
> take care,
>   Gerd
>