Re: [PATCH net-next v4] net: openvswitch: IPv6: Add IPv6 extension header support

From: Jakub Kicinski
Date: Thu Sep 16 2021 - 22:16:07 EST


On Thu, 16 Sep 2021 19:14:49 -0700 Jakub Kicinski wrote:
> On Thu, 16 Sep 2021 13:44:09 -0700 Toms Atteka wrote:
> > +/**
> > + * Parses packet and sets IPv6 extension header flags.
> > + *
> > + * skb buffer where extension header data starts in packet
> > + * nh ipv6 header
> > + * ext_hdrs flags are stored here
> > + *
> > + * OFPIEH12_UNREP is set if more than one of a given IPv6 extension header
> > + * is unexpectedly encountered. (Two destination options headers may be
> > + * expected and would not cause this bit to be set.)
> > + *
> > + * OFPIEH12_UNSEQ is set if IPv6 extension headers were not in the order
> > + * preferred (but not required) by RFC 2460:
> > + *
> > + * When more than one extension header is used in the same packet, it is
> > + * recommended that those headers appear in the following order:
> > + * IPv6 header
> > + * Hop-by-Hop Options header
> > + * Destination Options header
> > + * Routing header
> > + * Fragment header
> > + * Authentication header
> > + * Encapsulating Security Payload header
> > + * Destination Options header
> > + * upper-layer header
> > + */
>
> This is not a valid kdoc format, please read
> Documentation/doc-guide/kernel-doc.rst and double check for warnings
> with scripts/kernel-doc -none.

Also please make sure to CC appropriate maintainers on v5.
scripts/get_maintainers.pl is your friend there.