Re: [PATCH] Input: ads7846 - Make use of the helper function dev_err_probe()

From: Cai Huoqing
Date: Thu Sep 16 2021 - 22:29:46 EST


On 16 9月 21 21:34:26, Krzysztof Kozlowski wrote:
> On 16/09/2021 17:31, Cai Huoqing wrote:
> > When possible use dev_err_probe help to properly deal with the
> > PROBE_DEFER error, the benefit is that DEFER issue will be logged
> > in the devices_deferred debugfs file.
> > Using dev_err_probe() can reduce code size, and the error value
> > gets printed.
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
> > ---
> > drivers/input/touchscreen/ads7846.c | 7 ++-----
> > 1 file changed, 2 insertions(+), 5 deletions(-)
>
> You sent 32 independent patches. Do you expect us to copy-paste similar
> feedback on each of them? This would not make any sense. Please organize
> all your submissions in a series with:
>
> git format-patch -32
> git send-email ..... 00*
Ok, I'll try. but there are different owners for touchscreen/xxx,
is it ok to send them the whole series?
>
> The patches you sent were already sent before:
> https://lore.kernel.org/lkml/20200827185829.30096-1-krzk@xxxxxxxxxx/
>
> Best regards,
> Krzysztof