Re: [PATCH] crypto: img-hash: remove need for error return variable ret

From: Herbert Xu
Date: Thu Sep 16 2021 - 23:21:17 EST


On Fri, Sep 10, 2021 at 01:15:32PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The assignment to error return variable ret and then the jump to
> an error exit path can be simplified by just returning the error
> return at the failure point. This allows variable ret and the
> error return path to be removed. This cleans up a static analysis
> warninng that variable ret is being assigned (value never being
> used) and being re-assigned later.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/crypto/img-hash.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt