Re: [PATCH V5 2/2] arm64: dts: sc7280: Add volume up support for sc7280-idp

[skakit]

On 2021-09-17 00:32, Stephen Boyd wrote:
> Quoting Satya Priya (2021-09-16 06:21:38)
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi 
> > b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > index 371a2a9..cbbb0ee 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > @@ -12,6 +12,26 @@
> >  #include "pm8350c.dtsi"
> >  #include "pmk8350.dtsi"
> >
> > +/ {
> > +       gpio-keys {
> > +               compatible = "gpio-keys";
> > +               label = "gpio-keys";
> > +
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&key_vol_up_default>;
> > +
> > +               volume-up {
> > +                       label = "volume_up";
> > +                       gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>;
> > +                       linux,input-type = <1>;
> > +                       linux,code = <KEY_VOLUMEUP>;
>
> Is there an include for this define? Looks like
> <dt-bindings/input/input.h> should be added as well? Did you try
> compiling?

Yeah, it needs <dt-bindings/input/linux-event-codes.h> to be included. 
This header was included in pmk8350.dtsi which is added in this file.

> > +                       gpio-key,wakeup;
> > +                       debounce-interval = <15>;
> > +                       linux,can-disable;
> > +               };
> > +       };
> > +};
> > +
> >  &apps_rsc {
> >         pm7325-regulators {
> >                 compatible = "qcom,pm7325-rpmh-regulators";
> > @@ -284,6 +304,17 @@
> >
> >  /* PINCTRL - additions to nodes defined in sc7280.dtsi */
> >
> > +&pm7325_gpios {
> > +       key_vol_up_default: key-vol-up-default {
> > +               pins = "gpio6";
> > +               function = "normal";
> > +               input-enable;
> > +               bias-pull-up;
> > +               power-source = <0>;
> > +               qcom,drive-strength = <3>;
> > +       };
> > +};
> > +
> >  &qup_uart5_default {
> >         tx {
> >                 pins = "gpio46";
> > --
> > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
> > member
> > of Code Aurora Forum, hosted by The Linux Foundation