Re: [PATCH v2] extcon: extcon-axp288: use P-Unit semaphore lock for register accesses

From: Fabio Aiuto
Date: Fri Sep 17 2021 - 04:08:52 EST


Hello Hans,

On Thu, Sep 16, 2021 at 01:12:53PM +0200, Hans de Goede wrote:
> Hi,
<snip>
> >
> > Suggested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@xxxxxxxxx>
> > ---
> > Changes in v2:
> > - shortened patch title within 75 char
> > - added return value check in function
> > iosf_mbi_lock_punit_i2c_access() calls
>
>
> Actually your last version was v2, so this one should have
> been v3 (no need to resend it just for that).

oh sorry for mistake

>
> Other then that remark this looks good, thank you.

thank you for review

>
> Regards,
>
> Hans

@Chanwoo, do you need for me to resend a v3 or
you can take the patch as-is?

thank you,

fabio