Re: [PATCH 3/3] net: macb: add support for mii on rgmii

[Claudiu.Beznea]

Hi Andrew,

On 16.09.2021 16:03, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, Sep 15, 2021 at 09:47:21AM +0300, Claudiu Beznea wrote:
>> Cadence IP has option to enable MII support on RGMII interface. This
>> could be selected though bit 28 of network control register. This option
>> is not enabled on all the IP versions thus add a software capability to
>> be selected by the proper implementation of this IP.
> 
> Hi Claudiu
> 
> You are adding a feature without a user. That is generally not
> accepted.

That's true. For whatever reason I haven't added proper flags to
macb_config objects. I've send a new version with updates.

Thank you for your review,
Claudiu Beznea

> Could you please also extend one of the macb_config structs
> to make use of this?
> 
> Thanks
>         Andrew
>