Re: [PATCH 3/5] kcov: Allocate per-CPU memory on the relevant node.

From: Dmitry Vyukov
Date: Fri Sep 17 2021 - 10:40:20 EST


On Mon, 30 Aug 2021 at 19:26, Sebastian Andrzej Siewior
<bigeasy@xxxxxxxxxxxxx> wrote:
>
> During boot kcov allocates per-CPU memory which is used later if remote/
> softirq processing is enabled.
>
> Allocate the per-CPU memory on the CPU local node to avoid cross node
> memory access.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Acked-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>

> ---
> kernel/kcov.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kcov.c b/kernel/kcov.c
> index 80bfe71bbe13e..4f910231d99a2 100644
> --- a/kernel/kcov.c
> +++ b/kernel/kcov.c
> @@ -1034,8 +1034,8 @@ static int __init kcov_init(void)
> int cpu;
>
> for_each_possible_cpu(cpu) {
> - void *area = vmalloc(CONFIG_KCOV_IRQ_AREA_SIZE *
> - sizeof(unsigned long));
> + void *area = vmalloc_node(CONFIG_KCOV_IRQ_AREA_SIZE *
> + sizeof(unsigned long), cpu_to_node(cpu));
> if (!area)
> return -ENOMEM;
> per_cpu_ptr(&kcov_percpu_data, cpu)->irq_area = area;
> --
> 2.33.0
>