Re: [PATCH v2 06/13] mm: thp: introduce split_queue_lock/unlock{_irqsave}()

From: kernel test robot
Date: Fri Sep 17 2021 - 13:08:20 EST


Hi Muchun,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tj-cgroup/for-next]
[also build test ERROR on linus/master v5.15-rc1]
[cannot apply to hnaz-mm/master next-20210917]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Muchun-Song/Use-obj_cgroup-APIs-to-charge-the-LRU-pages/20210916-215452
base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
config: x86_64-randconfig-r034-20210916 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c8b3d7d6d6de37af68b2f379d0e37304f78e115f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/38a59259cef424526ba9abba4aa87ae066948218
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Muchun-Song/Use-obj_cgroup-APIs-to-charge-the-LRU-pages/20210916-215452
git checkout 38a59259cef424526ba9abba4aa87ae066948218
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> mm/huge_memory.c:516:1: error: expected external declaration
+static inline struct mem_cgroup *split_queue_memcg(struct deferred_split *queue)
^
1 error generated.


vim +516 mm/huge_memory.c

508
509 static inline struct deferred_split *page_memcg_split_queue(struct page *head)
510 {
511 struct mem_cgroup *memcg = page_memcg(head);
512
513 return memcg ? &memcg->deferred_split_queue : NULL;
514 }
515 #else
> 516 +static inline struct mem_cgroup *split_queue_memcg(struct deferred_split *queue)
517 {
518 return NULL;
519 }
520

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip